On Thu, 18 May 2006, Linus Torvalds wrote: > > > > But if people are ok with changing it from a "print a warning and ignore" > > into an _error_, we could just move it into "add_cache_entry()". > > This is the incremental patch to do that instead, if you prefer it. Thinking some more about it, I think I personally much prefer this. Especially as a quick look-through seems to say that there's actually a path through git-update-index too that allows a unverified filename to get into the index (the new "--unresolve" thing also misses the need to verify the path). Making it a fatal error makes it more obvious that the user did something fundamentally wrong. And the safety in doing it in add_cache_entry() just makes be happier, particularly in light of the above problem with --unresolve. That still leaves the question of whether we should also drop all the "verify_path()" calls in update-index.c, and make it fatal there too. I think we probably should. (At that point we could turn verify_path() back into a static function, this time local entirely to read-cache.c, rather than update-index.c) Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html