Re: [PATCH] Implement git-quiltimport

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 16 May 2006, Eric W. Biederman wrote:
> 
> So what we need for this case really is a way to mark the
> commit objects in such a way that git-fetch or git-merge
> would choke on the commit objects and refuse to merge.
> That way the changes could not easily propagate in the wild.
> Every user would at least have to specify a non-default option,
> that Linus at least would never specify.

No.

What we need is for your git-quiltimport to not generate the bogus commits 
in the first place!

Make it a damn error already.

If you want to have some stupid default to a non-existing and 
non-supported user, then do

	git-quiltimport --author="Bad User <baduser@xxxxxxxxxxxxxx>"

and get over it. Don't make the quiltimport script _default_ to a totally 
idiotic model that will just screw people over.

Or keep it as your personal script. I'm just saying that it should sure as 
hell not be used by any sane person in the format it is in now. Because, 
_by_default_, it now does something insane, which is bad bad bad. Which 
means that it shouldn't be merged by Junio.

		Linus
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]