On Wed, 10 May 2006, Linus Torvalds wrote: > > Yeah, that was totally bogus. It would re-allocate _part_ of an > allocation, but that allocation contained not just the index, but all the > hashes and the hash entries too! Actually, no, you got that part right. Mea culpa. It really only ended up being a problem when the area was moved, since the pointers into that area weren't updated. The alignment issue is real, but looking at the different structures, they'll all have pointers that end up being the real (and only) alignment constraint, so as a result, on any reasonable machine they all have the same alignment and things are fine. Junio - pls apply Nico's patch asap. It's correct, and fixes a really nasty problem. And I'll withdraw my other worries as "not consequential". Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html