Hi, On Sun, 7 May 2006, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > This is not enough. There are quite a few exit paths. Notice the "goto > > out_free"? That is where this must go. > > > > This patch is totally untested but obviously correct: > > except that many places you already close(fd) and > unlink(lock_file). Yes, my bad. I forgot to look for (and remove) them. Your patch looks fine to me. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html