Re: RFC: New diff-delta.c implementation

[Geert Bosch <bosch@xxxxxxxxxxx>]

On Apr 21, 2006, at 23:19, Nicolas Pitre wrote:
> It looks really interesting.
>
> It ignores the max_size argument but that is trivially fixed.
>
> Then it triggers some assertions in the code when running the test
> suite.
Yes, these were errors in the change to the GIT output format.
They were trivially fixed. More importantly, I didn't finalize
the indexing data, since the code was originally used in a stand-alone
program that would terminate after the diff.

> I did reformat it a bit to be more inline with the rest of GIT's  
> coding
> style (and to help me read it).  I'll look at fixing the issues I can
> fix and post it back.

Please apply the attached patch first.

  -Geert

BTW. It's a shame that we don't reuse the index when comparing one  
source
     against multiple targets. Creating the index takes about 70% of  
the time.

Attachment: pat
Description: Binary data