On Fri, 21 Apr 2006, Junio C Hamano wrote: > > Linus Torvalds <torvalds@xxxxxxxx> writes: > > > On Fri, 21 Apr 2006, Linus Torvalds wrote: > >> > >> This patch would have made things a lot more obvious. > > > > Actually, scratch that one, and use this one instead. Much better, and > > actually allows Bob's crazy PAGER environment variable to work, rather > > than just reporting an error about it. > > Agreed, this is much better than just punting. Sign-off? Yup, you can just go wild with the Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx> lines. My employment contract requires that everything I produce is open source ;) > BTW: The extended extended SHA1 is a great addition. I do not > usually have contrib/colordiff checked out (it is in "pu", not > in "next"), but I can easily do: > > git tar-tree pu:contrib/colordiff colordiff | tar xf - Ahh, yes. That is one situation where a sub-tree SHA1 makes more sense than most (the fact that it works with "git diff" and directory renames is likely more of a curiosity than anything widely useful, I think) > BTW: Allow me to try "git fmt-patch -1" ;-). Looks good to me. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html