Hi, On Wed, 12 Apr 2006, Junio C Hamano wrote: > Junio C Hamano <junkio@xxxxxxx> writes: > > > I wonder if you can also make this an independent option that > > prepends diffstat in front of the patch, just like the way the > > new flag --patch-with-raw flag prepends raw output in front of > > the patch. > > Clarification. > > Traditionally, we had diff-raw and diff-patch formats. > We can think of --name-status and --name-only variants of > diff-raw (just like different --abbrev settings give different > visuals for diff-raw). Until very recently, these were either-or > output formats, but for Cogito we added an option to show both. > > We could reorganize the output format options to: > > - diff-raw and its name variants > - diff-stat > - diff-patch > > and have (internally) three bools to specify which ones to > output, in the above order. The recent --patch-with-raw would > flip bit #0 (show raw) and bit #2 (show patch) on. It is very > likely that diff-stat followed by diff-patch would be a popular > format (that is what git-format-patch does), and it also is > conceivable that diff-raw with diff-stat but without diff-patch > might turn out to be useful for some people. That sounds plausible. Note that if diff-stat and diff-patch are turned on, the patch generating code will be called twice. I do not think it is sensible (or robust, for that matter) to cache the patch for this case. > Also, I forgot to mention, but would it be useful to have a > diffstat to show --cc? It is unclear, without much thinking, > what the numbers would mean, though... I thought long and hard about that. But how would you display it? You can have lines starting with "+ ", " +", "--", etc. The only half-way reasonable approach I found was to display the diffstat against each parent individually. Since it would be a bit involved to implement that, I wanted to think about it a bit longer, if it really makes sense. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html