Dear diary, on Sun, Apr 09, 2006 at 11:45:37AM CEST, I got a letter where Junio C Hamano <junkio@xxxxxxx> said that... > Petr Baudis <pasky@xxxxxx> writes: > > > Now, the -c option documentation says: > > > > It shows the differences from each of the parents to the merge > > result simultaneously, instead of showing pairwise diff between > > a parent and the result one at a time, which '-m' option output > > does. > > > > This sounds as exactly what I want. Well, the only problem is that the > > same diff command as above with -c option added produces no diff at all, > > just the header and commit messages. Did I misunderstand the -c > > description and does it do something different? > > The --combined diff option is to show merges more sensibly than > plain -m option. Now, the definition of "sensible" is to say > that a merge is not interesting if it takes a version from one > of the parents. The paths whose results do not match any of the > parents' version are deemed interesting and are shown. > > I think you could tweak and give an option to intersect_paths() > in combine-diff.c, so that paths that match one of the parents > are also included in the output. I haven't thought about it too > much, but my gut feeling is it would not be very involved > change. Aha, thanks! I actually think this is more sensible to do, so now I'm only pondering if in cg-log -f it is more useful to show the list of files changed relative to the first parent or the files which were subjected to a content merge... --- This tries to clarify the -c/-cc documentation and clean up the style and grammar. Signed-off-by: Petr Baudis <pasky@xxxxxxx> --- Documentation/git-diff-tree.txt | 25 ++++++++++++++++--------- 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/Documentation/git-diff-tree.txt b/Documentation/git-diff-tree.txt index 9153e4c..d7e529b 100644 --- a/Documentation/git-diff-tree.txt +++ b/Documentation/git-diff-tree.txt @@ -60,7 +60,8 @@ separated with a single space are given. -m:: By default, "git-diff-tree --stdin" does not show differences for merge commits. With this flag, it shows - differences to that commit from all of its parents. + differences to that commit from all of its parents. See + also '-c'. -s:: By default, "git-diff-tree --stdin" shows differences, @@ -81,19 +82,25 @@ separated with a single space are given. git-diff-tree outputs a line with the commit ID when applicable. This flag suppressed the commit ID output. --c,--cc:: - These flags change the way a merge commit is displayed +-c:: + This flag changes the way a merge commit is displayed (which means it is useful only when the command is given one <tree-ish>, or '--stdin'). It shows the differences - from each of the parents to the merge result - simultaneously, instead of showing pairwise diff between - a parent and the result one at a time, which '-m' option - output does. '--cc' further compresses the output by - omiting hunks that show differences from only one + from each of the parents to the merge result simultaneously + instead of showing pairwise diff between a parent and the + result one at a time (which is what the '-m' option does). + Furthermore, it lists only files which were modified + in both parents. + +-cc:: + This flag changes the way a merge commit patch is displayed, + in a similar way to the '-c' option. It implies the '-c' + and '-p' options and further compresses the patch output + by omitting hunks that show differences from only one parent, or show the same change from all but one parent for an Octopus merge. When this optimization makes all hunks disappear, the commit itself and the commit log - message is not shown, just like any other "empty diff" cases. + message is not shown, just like in any other "empty diff" case. --always:: Show the commit itself and the commit log message even -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Right now I am having amnesia and deja-vu at the same time. I think I have forgotten this before. - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html