On Sun, 2 Apr 2006, Jason Riedy wrote: > > Might as well ape the sigaction change in read-tree.c to avoid > the same potential problems. Looks good. I didn't realize we had the exact same code duplicated. I guess it's small enough that there isn't a huge win in moving it to some common file.. Does somebody have access to Solaris to verify that this all actually does fix it? I obviously believe it will, since this just explains the symptoms to a tee, but it would still be good to have an actual confirmation by somebody who has access to a Solaris environment. > Also add a NO_SA_RESTART option in the Makefile in case someone > doesn't have SA_RESTART but does restart (maybe older HP/UX?). > We want the builder to chose this specifically in case the > system both lacks SA_RESTART and does not restart stdio calls; > a compat #define in git-compat-utils.h would silently allow > broken systems. I do believe that we already require POSIX.2 functionality (regex, fnmatch, C90 compiler), which implies that git probably wouldn't compile anyway on things that are _really_ ancient. I think SA_RESTART was part of the original POSIX.1 specs, so anybody that doesn't have it is likely to not have a lot of other things we rely on too. There are other SA_* flags that aren't as standard, but I'd expect SA_RESTART to be everywhere (or it likely doesn't have sigaction() at all..). But hey, I certainly don't have really old HP-UX to test either. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html