On Sun, 2 Apr 2006, Junio C Hamano wrote: > Linus Torvalds <torvalds@xxxxxxxx> writes: > > > This is the "letter of the law" version of using fgets() properly in the > > face of incredibly broken stdio implementations. We can work around the > > Solaris breakage with SA_RESTART, but in case anybody else is ever that > > stupid, here's the "safe" (read: "insanely anal") way to use fgets. > > Did you mean this as a real change or a demonstration? The > sigaction change is a real fix, but somehow I find this one > similar to the "(void*) NULL" thing you objected earlier (which > was not merged because I agreed with your argument)... I don't have any really strong opinions on it. I think that any libc that needs the "ferror()" test + EINTR loopback is totally broken. I would happily say that people should just not use a development platform that is that horrible. But the fact that Solaris actually had that as a real problem (never mind that we could work around it another way) just makes me go "Hmm..". So I _think_ we're safe with just the "sigaction()" diff. Neither of the patches _should_ make any difference at all on a sane platform. Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html