Junio C Hamano wrote:
Petr Baudis <pasky@xxxxxxx> writes:
I still don't get what's wrong on what I'm proposing. I'm not seeing the
disadvantages, if there are any.
The only thing I think there is is that I do not get what you
are proposing ;-), since I am not paying full attention while at
day-job.
If you are proposing to root --use-separate-remote not at
refs/remotes but refs/remotes/origin/, I think it makes kind of
sense. It would make tons of sense _if_ dealing more than one
remote repository is the norm, but otherwise you would have an
extra level of directory refs/remotes which almost always have
only one subdirectory 'origin' and nothing else, which is
pointless.
afaiu, this is exactly what Pasky's proposing, and I agree. We could
then teach 'git diff origin master' to mean 'origin/master' *if* no
other tag/branch is found in the lookup order. I think it makes sense to
do searching like this, for a ref named foo
(current order, with .git/, .git/refs/, etc...)
.git/refs/remotes/foo
.git/refs/remotes/foo/master
That way the only extra dwimery would be to add "remotes" after "heads"
under .git/refs and accept directory in .git/remotes/ as ref and tack on
'/master' at the end of it as the last option to search. For a specific
branch on an imported remote, one would have to say "jc/next". This
means we still only handle 'master' specially so we don't introduce any
new protected or special names.
I am not sure if you are also advocating to map (somehow) origin
to remotes/origin/master (or whatever branch remote's HEAD
points at), but if so I am not quite sure what its semantics
would be. Which remote branch would you pick (that would not
necessarily be "master") and where are you going to record that
and when. It all sounds to me complicating things
unnecessarily.
Not too much so, I think. I'll look into it tonight, although I'm not
very familiar with the core stuff so possibly (/ hopefully) someone else
will beat me to it.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html