Petr Baudis <pasky@xxxxxxx> writes: > Dear diary, on Sat, Mar 18, 2006 at 11:27:45AM CET, I got a letter > where Alexandre Julliard <julliard@xxxxxxxxxx> said that... >> Without this patch, the last line of an exclude file is silently >> ignored if it doesn't end with a newline. >> >> Signed-off-by: Alexandre Julliard <julliard@xxxxxxxxxx> > > $ echo -en "a\nb" | wc -l > 1 > > In UNIX, a line is a string terminated by a newline, therefore the blob > past the last newline character is not really a line at all. ;-) > > Perhaps a warning might be in order. Why don't you just add the trailing > newline to the file? Of course I can do that, but I think that if a user entered something on the last line it's a safe bet they didn't mean for it to be ignored; and since it's trivial to DTRT here, I don't see why we shouldn't. -- Alexandre Julliard julliard@xxxxxxxxxx - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html