Linus Torvalds <torvalds@xxxxxxxx> writes: > The "score" calculation for diffcore-rename was totally broken. > > It scaled "score" as > > score = src_copied * MAX_SCORE / dst->size; > > which means that you got a 100% similarity score even if src and dest were > different, if just every byte of dst was copied from src, even if source > was much larger than dst (eg we had copied 85% of the bytes, but _deleted_ > the remaining 15%). Your reading of the code is correct, but that is deliberate. > /* How similar are they? > * what percentage of material in dst are from source? > */ I wanted to say in such a case that dst was _really_ derived from the source. I think using max may make more sense, but I need to convince myself by looking at filepairs that this change stops detecting as renames, and this change starts detecting as renames. - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html