On Sun, 5 Mar 2006, Junio C Hamano wrote: > > I abused SHOWN when I did --objects-edge with > mark_edge_parents_uninteresting modification in > eb38cc689e84a8fd01c1856e889fe8d3b4f1bfb4, but probably it can be > modified to use SEEN. Ahh, no. SEEN is different from SHOWN. SHOWN means that we've actually shown that commit, while SEEN just means that we've added it to the list (but it might be uninteresting, for example). I think you did exactly the right thing wrt SHOWN. That said, the revision list walker should never see a SHOWN commit on the list, because it is the thing that sets SHOWN as it removes the entry from the list (and it should never get re-added, due to SEEN). Linus - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html