Fredrik Kuivinen <freku045@xxxxxxxxxxxxxx> writes:
> The default output mode is slightly different from git-annotate's.
> However, git-annotate's output mode can be obtained by using the
> '-c' flag.
It might be better to default to human readable and make the
script consumption format an option, if only to reduce typing.
> diff --git a/Makefile b/Makefile
> index b6d8804..eb1887d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -534,6 +534,10 @@ git-rev-list$X: rev-list.o $(LIB_FILE)
> $(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> $(LIBS) $(OPENSSL_LIBSSL)
>
> +git-blame$X: blame.o $(LIB_FILE)
> + $(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> + $(LIBS) -lm
> +
I wonder what it is about to link this binary different from others...
> +char* format_time(unsigned long time, const char* tz)
> +{
> + static char time_buf[128];
> + time_t t = time;
> +
> + strftime(time_buf, sizeof(time_buf), "%Y-%m-%d %H:%M:%S ", gmtime(&t));
> + strcat(time_buf, tz);
> + return time_buf;
> +}
I think this shows GMT with time offset, which is compatible
with the human readable time Johannes did to git-annotate. I do
not know what timezone CVS annotate shows its dates offhand (it
seems to only show dates). Johannes, is this an attempt to
match what CVS does?
I am wondering if we want to be in line with the date formatting
convention used for our commits and tags, that is, to show local
timestamp with timezone. The code to use would be show_date()
from date.c if we go that route.
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html