Ryan Anderson <ryan@xxxxxxxxxxxxxx> writes: >> git-annotate is dying when a patch is missing trailing newline. There >> _are_ valid situations where code files are not expected to have >> trailing newlines. Just thing of that glorious programming language, >> PHP. > > Can you point me at a tree that has this problem? I'll see what I can > do about fixing it tonight. $ cat script #!/bin/sh mkdir test-dir || exit cd test-dir git init-db echo 'A quick brown fox jumps over the' >file echo 'lazy dog' | tr -d '\012' >>file git add file git commit -a -m 'Initial.' echo 'A quick brown fox jumps over the' >file echo 'lazy dog' | tr -d '\012' >>file git commit -a -m 'Second.' git annotate file $ rm -fr test-dir $ sh script defaulting to local storage area Committing initial tree 2850f9a320885b57bb410baffe972b19b17e9270 Use of uninitialized value in string ne at /home/junio/bin/Linux/git-annotate line 308, <$kid> line 10. Use of uninitialized value in sprintf at /home/junio/bin/Linux/git-annotate line 309, <$kid> line 10. Line 3 (3) does not match: | No newline at end of file | 1e698bcc5b142b542bf99a1a6f17864bc709dbf5 => 780bca516444e94219d4158b7fea97e763dcee6e $ echo $? 9 $ exit - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html