Re: [PATCH] Add git-annotate, a tool for assigning blame.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ryan Anderson wrote:
On Tue, Feb 28, 2006 at 09:27:36AM +0100, Fredrik Kuivinen wrote:

On Mon, Feb 20, 2006 at 04:01:56PM -0800, Junio C Hamano wrote:

Fredrik Kuivinen <freku045@xxxxxxxxxxxxxx> writes:


I have also been working on a blame program.

...


BTW, these days I always compile things with
	-Wall -Wdeclaration-after-statement

which caught quite a many.

Just out of curiosity, why do you prefer declarations before
statements?


I won't speak for Junio, but the explanations I've heard in the past are
basically:

1) It keeps all declarations in one spot.
2) If your function is complicated enough to not need a variable until
fairly far into the function, it probably should be two (or more) functions.


3) Not all compilers support it.

--
Andreas Ericsson                   andreas.ericsson@xxxxxx
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]