On Mon, 27 Feb 2006, Johannes Schindelin wrote: > > beware of that patch. It breaks at least one thing: cloning a repository > with a tag pointing to a tag object (the tag is cloned, but not the tag > object). > > Sorry to not fix it right away, but I am just too tired. Ahh. I know what it is. I'm pretty sure this trivial and stupid patch on top of the patch I sent out should fix it. Duh. I moved "pending_objects" into the "revs" structure, but didn't remove the stale one, along with its use. Linus --- diff --git a/rev-list.c b/rev-list.c index d1c52a6..e9e371c 100644 --- a/rev-list.c +++ b/rev-list.c @@ -214,8 +214,6 @@ static struct object_list **process_tree return p; } -static struct object_list *pending_objects = NULL; - static void show_commit_list(struct commit_list *list) { struct object_list *objects = NULL, **p = &objects, *pending; @@ -226,7 +224,7 @@ static void show_commit_list(struct comm if (process_commit(commit) == STOP) break; } - for (pending = pending_objects; pending; pending = pending->next) { + for (pending = revs.pending_objects; pending; pending = pending->next) { struct object *obj = pending->item; const char *name = pending->name; if (obj->flags & (UNINTERESTING | SEEN)) - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html