Linus Torvalds <torvalds@xxxxxxxx> wrote: > > > > On Sat, 25 Feb 2006, Andrew Morton wrote: > > > > I'd suggest a) git will simply refuse to apply such a patch unless given a > > special `forcing' flag, b) even when thus forced, it will still warn and c) > > with a different flag, it will strip-then-apply, without generating a > > warning. > > This doesn't do the "strip-then-apply" thing, but it allows you to make > git-apply generate a warning or error on extraneous whitespace. > > Use --whitespace=warn to warn, and (surprise, surprise) --whitespace=error > to make it a fatal error to have whitespace at the end. Thanks. But it defaults to nowarn. Nobody will turn it on and nothing improves. > Totally untested, of course. But it compiles, so it must be fine. Who cares, as long as the patch doesn't add trailing whitespace? ) ;) > HOWEVER! Note that this literally will check every single patch-line with > "+" at the beginning. Which means that if you fix a simple typo, and the > line had a space at the end before, and you didn't remove it, that's still > considered a "new line with whitespace at the end", even though obviously > the line wasn't really new. > > I assume this is what you wanted, and there isn't really any sane > alternatives (you could make the warning activate only for _pure_ > additions with no deletions at all in that hunk, but that sounds a bit > insane). Yup. So by the time we've patched every line in the kernel, it's trailing-whitespace-free. - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html