Timo Hirvonen <tihirvon@xxxxxxxxx> writes:
> - Use setenv() instead of putenv()
> - Fix -Wundef -Wold-style-definition warnings
> - Make pll_free() static
I think the last one makes sense, and I can see why some people
may prefer -Wundef but I am not sure about the first one. Care
to defend why we should prefer setenv()? IIRC, initially we did
not use setenv() anywhere because certain platforms only had
putenv().
> diff --git a/fsck-objects.c b/fsck-objects.c
> @@ -483,7 +483,7 @@ int main(int argc, char **argv)
> if (standalone && check_full)
> die("Only one of --standalone or --full can be used.");
> if (standalone)
> - putenv("GIT_ALTERNATE_OBJECT_DIRECTORIES=");
> + setenv("GIT_ALTERNATE_OBJECT_DIRECTORIES", "", 1);
For platforms with only putenv we did this; here, what we really
wanted to do was unsetenv.
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html