Junio C Hamano <junkio@xxxxxxx> wrote: > ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes: > > > Is this something that we always want to test for in the porcelain > > or do we want to move a check into git-commit-tree? > > > > For getting a reasonable error message where you have the test > > seems to be the only sane place, but having the check deeper > > down would be more likely to catch this kind of thing. > > I think 99.9% of the time it is a mistake if a single-parented > commit has the same tree as its parent commit has, so having a > check in commit-tree may not be a bad idea. This would break importers, more than 0.1% I think... Arch definitely allows empty commits for getting log messages in. SVN forbids them from their POV, but they also have things that we can't see when we import (properties like: mime, externals, eol-style) causing us to write the same tree twice. Not sure about CVS... Maybe a flag such as --force could be added. -- Eric Wong - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html