Commit:
b5b16990f8b074bd0481ced047b8f8bf66eee6dc
Prevent git-upload-pack segfault if object cannot be found
is causing some really annoying noise being sent to stderr on some of
my older non-packed repositories:
$ git status
# On branch refs/heads/b4
unable to open object pack directory: .git/objects/pack: No such file or directory
nothing to commit
$ git-rev-list --pretty=oneline v8.01.04b3..
unable to open object pack directory: .git/objects/pack: No such file or directory
a7401b7109fb2cba7de41a0e30dfe6aa41690ea8 No ZIO.
...
Here's the relevant hunk:
> diff --git a/sha1_file.c b/sha1_file.c
> index 3d11a9b..f08b1d6 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -551,8 +551,10 @@ static void prepare_packed_git_one(char
> sprintf(path, "%s/pack", objdir);
> len = strlen(path);
> dir = opendir(path);
> - if (!dir)
> + if (!dir) {
> + fprintf(stderr, "unable to open object pack directory: %s: %s\n", path, strerror(errno));
> return;
> + }
> path[len++] = '/';
> while ((de = readdir(dir)) != NULL) {
> int namelen = strlen(de->d_name);
Could we drop this fprintf to stderr?
Thanks,
Andrew
-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html