P.S.: As you can guess, I never took the time to actually look into re-implementing the clone as an available tool in your plug-in. That was a cool feature, but I don't think if I will make the time to add it (as I don't need it other than it's cool :P). So feel free to just add it back if ever you manage to fix the issue previously raised. :-) On Thu, Jan 24, 2019 at 1:23 AM Jehan Pagès <jehan.marmottard@xxxxxxxxx> wrote: > Hi Elad, > > Sorry for the delay before inclusion. I must admit I completely forgot > (just while doing something else tonight, I suddenly remembered this > proposal for an updated Spyrogimp!). > > So I took some time tonight to review again, then finally pushed your > plug-in. > I just did some trailing whitespace cleaning, and also simply renamed it > to "plug-in-spyrogimp", basically dropping the "Plus" part. I understand > that the "plus" was about saying it is another more advanced plug-in, but I > prefer to think of it as just a new version of the same plug-in (even > though a total rewrite), so that we can later on just drop the old version > (maybe when moving to GIMP 3?). When this happens, if there is only one > plug-in and it is named "plus", it makes not much sense. I guess. :-) > > Anyway here is the commit for the initial code you provided, as-is: > https://gitlab.gnome.org/GNOME/gimp/commit/a702c6a3270485e1320521c89499e1b3270477d4 > And here my commit with the slight changes: > https://gitlab.gnome.org/GNOME/gimp/commit/e91028df2f9669fe2d98f05a969692695a62003f > > I hope you will stay around for any fixes which might be needed later on. > :-) > Do you have a GNOME gitlab account? > > Jehan > > On Sun, Nov 18, 2018 at 9:24 PM Jehan Pagès <jehan.marmottard@xxxxxxxxx> > wrote: > >> Hi! >> >> On Sun, Nov 18, 2018 at 8:58 PM Elad Shahar <dawn.ever@xxxxxxxxx> wrote: >> >>> Hi Jehan, >>> >>> Thanks for the review! >>> The new version is here >>> <https://www.dropbox.com/s/r1qfmk4r2oc3off/spyro_plus.py?dl=0> >>> >>> Here is what I have done: >>> >>> * The problem with the background color happens only in some themes, >>> when using a notebook where the tabs are set to be invisible. That was what >>> I was using. >>> I did not manage to make the odd background color go away, so I just >>> changed the UI to use a notebook with the tabs visible. So this should be >>> solved. >>> >>> * As for the clone issue, I did not manage to fix the issue, so I just >>> removed "Clone" from the list of tools. >>> >> >> Sad! The clone source seemed like a cool feature. I'll see if I can fix >> this myself then. :-) >> >> Jehan >> >> >>> Thanks! >>> Elad >>> >>> On Wed, Nov 14, 2018 at 6:54 PM Jehan Pagès <jehan.marmottard@xxxxxxxxx> >>> wrote: >>> >>>> Hi! >>>> >>>> On Sun, Oct 14, 2018 at 12:47 AM Elad Shahar <dawn.ever@xxxxxxxxx> >>>> wrote: >>>> >>>>> Hi Jehan, >>>>> >>>>> Thanks for your feedback! >>>>> The new version is here >>>>> <https://www.dropbox.com/s/r1qfmk4r2oc3off/spyro_plus.py?dl=0> . >>>>> >>>>> Here is what I have done: >>>>> >>>>> * I made "Esc" close the dialog (and cancel the pattern). >>>>> * The issue with the broken icon was part of a larger issue that made >>>>> the plugin look different than other plugins. This was resolved by using >>>>> gimpui.py >>>>> * I added a non-interactive API. >>>>> * I made the dialog less tall, by grouping parameters in notebook tabs. >>>>> >>>>> In addition: >>>>> >>>>> * Using the "selection" shape now draws multiple shapes - if several >>>>> paths were generated from the selection-to-path conversion. >>>>> * Several new multi-sided shapes were added as fixed rings, with >>>>> additional options. >>>>> These produce drawings similar to many guilloche patterns. Examples >>>>> for the new shapes are here >>>>> <https://www.dropbox.com/s/6ae238njoafnqe7/example.png?dl=0>. >>>>> * I added "long-gradient" support, that spreads across the entire >>>>> pattern. >>>>> This was available in the previous spyrogimp.scm, and produces nice >>>>> results which are difficult to obtain when trying to tune the gradient from >>>>> tool settings. >>>>> * Improved the speed of incremental drawing by using gobject.idle_add >>>>> instead of timeouts. >>>>> >>>>> I'd be glad to fix any other issues. >>>>> >>>> >>>> So I finally reviewed. >>>> >>>> * The background color of self.pattern_notebook is always white, which >>>> is especially a problem with darker themes. Is it only for me? Don't you >>>> have this issue too? I had a look and am unsure where this comes from >>>> though (maybe it's a problem in the theme, but I have no idea). >>>> >>>> * I had once a warning about broken undo when setting "Clone" (then I >>>> had a warning about no clone source, but this one is normal) then canceling >>>> with Esc. >>>> >>>> Apart from these, it looks good here. :-) >>>> >>>> Jehan >>>> >>>> >>>>> If the plugin is indeed updated in the repository, could I write >>>>> documentation for the manual? >>>>> >>>>> Thanks! >>>>> Elad >>>>> >>>>> On Sun, Sep 16, 2018 at 10:34 PM Jehan Pagès < >>>>> jehan.marmottard@xxxxxxxxx> wrote: >>>>> >>>>>> Hi Elad, >>>>>> >>>>>> On Sat, Sep 15, 2018 at 4:14 PM Elad Shahar via gimp-developer-list < >>>>>> gimp-developer-list@xxxxxxxxx> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Long ago, I have written a Spyrogimp plugin in scheme. The plugin is >>>>>>> currently included in gimp (under Filters -> Render -> Spyrogimp). >>>>>>> Now I >>>>>>> have done a rewrite in python which I hope is a big improvement: >>>>>>> >>>>>>> * It provides immediate feedback, by incremental drawing to a >>>>>>> temporary >>>>>>> layer. >>>>>>> * Supports using more tools to draw the pattern (e.g. stroke). >>>>>>> * You can use a non-rectangular selection to serve as the shape of >>>>>>> the >>>>>>> "fixed ring". This is done by converting the selection to a path. If >>>>>>> the >>>>>>> path has more than one stroke, then a pattern is drawn only for one >>>>>>> of >>>>>>> them. ( I might improve that in the near future). >>>>>>> * There is an additional way to specify the pattern, that is >>>>>>> compatible >>>>>>> with the notation in the toy kit Spirograph manuals. >>>>>>> * Lots of tooltips >>>>>>> >>>>>>> If you want to try it, you can download it here: >>>>>>> https://www.dropbox.com/s/r2t5o4n4kyvtkmi/spyro.py?dl=0 >>>>>> >>>>>> >>>>>> That's a cool update, and we could replace the old spyro by the new >>>>>> one (or on 2.10 at least deprecate the old one and hide it from menus but >>>>>> leave it alongside for the PDB API). >>>>>> I wonder if this could not be a GEGL operation also by the way, >>>>>> rather than a plug-in. >>>>>> >>>>>> Feedback is welcome. >>>>>>> >>>>>> >>>>>> * Would be nice that hitting "Esc" close the dialog (and cancel the >>>>>> pattern). >>>>>> * On my desktop (GNOME on Fedora 28), the dialog shows a broken icon. >>>>>> * The dialog is much too high. On my screen, part of it is out of >>>>>> screen (the buttons in particular) so I need to use the Super key + left >>>>>> mouse click trick to move the window. It would be nice to rearrange the >>>>>> buttons differently or hide a scrollbar. >>>>>> * Your new plug-in doesn't provide a non-interactive API as the old >>>>>> one used to. I think this would be quite needed to be able to replace the >>>>>> old plug-in correctly. >>>>>> >>>>>> Apart from these, that is a really cool plug-in. I would update the >>>>>> repository with this new plug-in once these few points are fixed. :-) >>>>>> If you answer by email, make sure to name me so that I don't miss the >>>>>> email (I have filters allowing me to see when I am named so that I don't >>>>>> miss mailing list emails targeted at me). >>>>>> Thanks! >>>>>> >>>>>> Jehan >>>>>> >>>>>> >>>>>>> >>>>>>> Elad >>>>>>> _______________________________________________ >>>>>>> gimp-developer-list mailing list >>>>>>> List address: gimp-developer-list@xxxxxxxxx >>>>>>> List membership: >>>>>>> https://mail.gnome.org/mailman/listinfo/gimp-developer-list >>>>>>> List archives: https://mail.gnome.org/archives/gimp-developer-list >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> ZeMarmot open animation film >>>>>> http://film.zemarmot.net >>>>>> Liberapay: https://liberapay.com/ZeMarmot/ >>>>>> Patreon: https://patreon.com/zemarmot >>>>>> Tipeee: https://www.tipeee.com/zemarmot >>>>>> >>>>> >>>> >>>> -- >>>> ZeMarmot open animation film >>>> http://film.zemarmot.net >>>> Liberapay: https://liberapay.com/ZeMarmot/ >>>> Patreon: https://patreon.com/zemarmot >>>> Tipeee: https://www.tipeee.com/zemarmot >>>> >>> >> >> -- >> ZeMarmot open animation film >> http://film.zemarmot.net >> Liberapay: https://liberapay.com/ZeMarmot/ >> Patreon: https://patreon.com/zemarmot >> Tipeee: https://www.tipeee.com/zemarmot >> > > > -- > ZeMarmot open animation film > http://film.zemarmot.net > Liberapay: https://liberapay.com/ZeMarmot/ > Patreon: https://patreon.com/zemarmot > Tipeee: https://www.tipeee.com/zemarmot > -- ZeMarmot open animation film http://film.zemarmot.net Liberapay: https://liberapay.com/ZeMarmot/ Patreon: https://patreon.com/zemarmot Tipeee: https://www.tipeee.com/zemarmot _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
