On Sat, Apr 7, 2018 at 5:17 PM, Partha Bagchi <partha1b@xxxxxxxxx> wrote: > > > On Sat, Apr 7, 2018 at 5:03 PM, Ell <ell_se@xxxxxxxxx> wrote: > >> On Sat, 7 Apr 2018 15:43:30 -0400 >> Partha Bagchi <partha1b@xxxxxxxxx> wrote: >> >> > My apologies. I should have framed that as 2 different issues. One >> > about >> > the compilation and the other that we should probably be using C++14 >> > (or 11) instead of gnu++11. >> >> The exact flag we use is not hard coded, it's determined by >> AX_CXX_COMPILE_STDCXX() during configure. We *could* ask it for a >> strictly standard-compliant mode, but we're not that concerned about >> it. We might want to use some GCC extension, based on some other >> configure test, or whatnot. >> >> > >> > In any case, the verbose mode may not be particularly helpful: >> > >> > [...] >> > >> > In there you can see "-xobjective-c" is being used to compile >> > gimp-parallel.cc. Also, you're seeing -std=c++14 because I have >> > CXXFLAGS defined that way. >> >> Thanks. So, we've been passing "-xobjective-c" unconditionally to all >> compiled files on Mac. Commit 06950be7f0 should fix that, only passing >> it when compiling C files. >> >> -- >> Ell >> > > I was about to post that!! > > Anyway, I did a git pull and something went haywire. I don't know what! I > even did make distclean. I am getting realms of text starting with: > > Making all in tools >> cd .. && /bin/sh /Users/partha/projects/src/gimp/gitsource/std/gimp/missing >> automake-1.15 --gnu tools/Makefile >> cd .. && /bin/sh ./config.status tools/Makefile depfiles >> config.status: creating tools/Makefile >> config.status: executing depfiles commands >> CCLD gimptool-2.0 >> gimptool.o:1:1: error: source file is not valid UTF-8 >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:2: error: source file is not valid UTF-8 >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:3: error: source file is not valid UTF-8 >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:4: error: source file is not valid UTF-8 >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:5: error: expected identifier or '(' >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:6: warning: null character ignored [-Wnull-character] >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> ^ >> gimptool.o:1:7: warning: null character ignored [-Wnull-character] >> <CF><FA><ED><FE><U+0007><U+0000><U+0000><U+0001><U+0003>< >> U+0000><U+0000><U+0000><U+0001><U+0000><U+0000><U+0000>< >> U+0004><U+0000><U+0000><U+0000><F0><U+0002><U+0000>... >> > > ??? > > Confirmed. It's something you did!! :) :) Anyway, reverted back to previous head and c++14 error is back but all the above is gone. _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list