After having used this feature for a few weeks now in production work, I find it saves a lot of clicks/time, and I'm happy to have it applied to trunk as-is. I think other professional workflows will benefit greatly from it in various ways. -C On Thu, May 26, 2016 at 3:08 PM, Ben <draekko.software@xxxxxxxxx> wrote: > ============ > >> Date: Wed, 25 May 2016 18:36:36 +0100 >> From: C R >> >> >> It's definitely faster, and more convenient. I also like the fact that >> ctrl+shift+clicking a masked layer removes the mask. >> It makes a pain-free toggle, I can see myself using it a lot. >> >> The only thing I would add is that if there is a selection on the canvas, >> that the mask be made from that selection. >> More often than not I'm making a mask out of the current selection, so it >> would save me several hotkey presses after using the new ctrl+shift+click >> layer mask feature. >> > Thanks for trying it out. You can also use ctrl-alt-click to bring up the > dialog instead of the predefined value. > > ============ > > Date: Wed, 25 May 2016 22:30:11 +0300 >> From: Alexandre Prokoudine >> Something I'm not sure about is that Ctrl+Shift+Click on the mask >> preview toggles visibility of the mask. I never used this shortcut on >> the mask before, so I'm not certain if it had existed before or if it >> has just been added as part of the patch. In other words: is it >> expected behavior? >> > There was no such shortcut till the patch. Using it either adds or removes > a layer mask (if it exists on the layer). > > Another thing is that another mask-related setting -- default quick >> mask color -- is on a different tab. Should they be on the same tab >> instead? >> > I don't think so. > >> >> Other than that, I'd be happy to see the patch applied. >> > Thanks for trying it out. You can also use ctrl-alt-click to bring up the > dialog instead of the predefined value. > > Ben > > _______________________________________________ > gimp-developer-list mailing list > List address: gimp-developer-list@xxxxxxxxx > List membership: > https://mail.gnome.org/mailman/listinfo/gimp-developer-list > List archives: https://mail.gnome.org/archives/gimp-developer-list > _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list