________________________________________ >From: Jehan Pagès <jehan.marmottard@xxxxxxxxx> >Sent: 21 February 2016 17:24 >To: Kevin Payne >Cc: gimp-developer-list@xxxxxxxxx Subject: Re: Icon sizes required >Hi, On Sun, Feb 21, 2016 at 1:23 PM, Kevin Payne <paynekj@xxxxxxxxxxx> wrote: > But that is partly my point - The original icons are apparently the wrong size, so my question stands: How to determine what sizes are required? > >I had already noticed this discrepancy in our code. We are actually >requesting for a GTK_ICON_SIZE_BUTTON which is 20x20 in GTK+2 >(interestingly in GTK+3, it is a 16x16). Yet the icons in the legacy >color icon theme are 22x22 (not 24x24); and since the default >acceptable "threshold" is 2 pixels, when requesting a 24x24 icons, >GTK+ gets the available 22x22 tool icons instead. >I'm not sure icons are actually re-scaled though. I think GTK+ simply >uses the smaller 22x22 icons as is, instead of the expected 24x24, >that's all. Not trying forcingly to match expectations. Though I >actually wondered as well, since if they were in fact rescaled, that >basically means our default theme had been providing definitely >not-pixel-perfect all along. >Jehan Just to be clear, I'm only referring to the gimp-gravity-* icons when I say they are 24x24 As for scaling - in 2.8, I agree that scaling doesn't take place and that icons are used the size they are provided at, which is where the problem in this bug comes in: https://bugzilla.gnome.org/show_bug.cgi?id=739469 However in 2.9, using the icon theme mechanism, if an icon isn't provided at the required size (+/- the tolerance, thanks I didn't know about that) then scaling of a different size is performed: http://imgur.com/98D3SLA And the size of the GTK named sizes is still controlled by the theme (until the change to GTK3): gtk-icon-sizes = "panel-menu=10,10 : panel=10,10 : gtk-button=20,20 : gtk-large-toolbar=24,24 : gtk-menu=16,16 : gtk-small-toolbar=18,18 : gtk-dnd=32,32 : gtk-dialog=48,48" So it's outside the control of the creator of the icon theme. At this point I think I might have to give up on the idea of pixel aligned icons as it looks like the icon theme mechanism is creating an unmanageable mess, which is a pity because it's a nice idea. Kevin _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
