Hi, On Mon, Nov 18, 2013 at 1:06 AM, Jehan Pagès <jehan.marmottard@xxxxxxxxx> wrote: > Hi again, > > On Mon, Nov 18, 2013 at 12:25 AM, Jehan Pagès > <jehan.marmottard@xxxxxxxxx> wrote: >> Hi, >> >> On Fri, Nov 15, 2013 at 9:41 AM, Michael Henning >> <drawoc@xxxxxxxxxxxxxxxxxx> wrote: >>> This was replied to just me, so I'm forwarding it to the entire list. >> >> Thanks Michael. >> >>> >>> ---------- Forwarded message ---------- >>> From: Andrew Pullins <android2772@xxxxxxxxx> >>> Date: Thu, Nov 14, 2013 at 2:15 AM >>> Subject: Re: GIMP Icons >>> To: Michael Henning <drawoc@xxxxxxxxxxxxxxxxxx> >>> >>> >>> >>>> > You have not answered to the question. What version is it *exactly*? >>>> > The last is 2.8.8. Just "2.8" is not enough, there has been 4 minor >>>> > versions in 2.8. Please check the About of the program. >>> >>> >>> here are some comments form my DeviantArt >>> >>> Linux >>> >>> Works fine on Debian Wheezy / Gimp 2.8.x >>> >>> Dark theme crashes on Ubuntu 12.04, but Light works fine. >> >> I just tested on my Linux Mint. The dark theme crashes too. >> So I tracked the bug. As I thought, the issue is in GTK+. I have fixed >> it on my locale development and will upload the patch tomorrow on >> Bugzilla (I want first to do a few more tests and see if it affects >> GTK+ 3 as well. But for now, I must sleep). > > Well in the end, I did not want to push it to tomorrow. So I just > tested and made the ticket now. > See https://bugzilla.gnome.org/show_bug.cgi?id=712536 > > With this patch, we will handle better broken themes. Just for your information, the patch has made it upstream and new stables releases of GTK+ are planned for this week. Not sure when it would make it to your distribution but when it will, the particular crashes you experienced will be fixed (unless there were other issues I could not discover) with GTK+ 2.24.23. This being said, even though GTK+ will be now robuster on a faulty theme, I would still suggest you to fix your theme with the indications I gave you earlier. Then you don't have to ask your users to wait for an updated GTK+. :-) Bye! Jehan > > In the meantime, you should fix your theme if you want it to work with > current GTK+. > In particular, just remove all the gap_file, gap_start_file and > gap_end_file in your gtkrc which do not correspond to an existing > image. These were the pieces of the gtkrc which was making GTK+ crash. > Regards, > > Jehan > >> >>> [...] >> >>>> > There seems to be a lot of missing icons in your set, and more >>>> > problematic, several errors in the gtkrc. >>>> > So that may explain why it does not work well (or at all) for some >>>> > people (maybe it depends on the version of GTK+ installed). The best >>>> > on your side would be to fix at least the gtkrc. >>> >>> >>> well I can see how I messed some icons, there are a lot. as for the >>> gtkrc I kinda just took a bunch of different themes mashed them >>> together and ctrl found colors till switching them out got the look I >>> wanted. I honestly have no idea what I'm doing with these themes. I >>> did not know there was anything wrong with the gtkrc and have no idea >>> where to start. I really wanted this to be a GMIP only theme, there >>> seems to be a lot of GIMIP themes out there that can be used for many >>> applications and there for have a lot of extra stuff that GIMP dose >>> not need. >> >> I see. Well if you just follow all the warning output in a terminal, >> you can at least track all the non-existent images and get rid of the >> references in the gtkrc. >> That would be already a good start. :-) >> >>>> > In any case, if really GIMP crashes because of this, that's not >>>> > normal. It should not crash on wrong input. Could you please open a >>>> > bug report: https://bugzilla.gnome.org/enter_bug.cgi?product=GIMP >>> >>> >>>> >>>> > Then a developer (maybe me) will look into it when we have some time, >>>> > and we'll try to reproduce the crash. >>> >>> >>> I will do so. >> >> Well, now that I have fixed the bug, I may as well take care of the >> bug ticket too, I guess. >> Thanks for the report anyway. >> >> Jehan _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
