Hi, On Wed, Nov 13, 2013 at 11:49 PM, peter sikking <peter@xxxxxxxxxxxx> wrote: > Jehan wrote: > >> Just checking master, currently when "overwrite" is shown, export-to >> is not grayed out but it is invisible. >> That means that it is active and can be run if you know the shortcut, >> but you can't export from the menu (for people who don't know >> shortcuts, new or casual users, etc.). >> Is it intended? I feel like this is a mistake and that "Export To" >> should always show up in the menu. >> I could easily fix this. > > yes this is intentional. the spec says: > > ‘The shortcut for the Export menu item shall remain active and map to invoking the Export As… command, sneaky, but true.’ > > I have done this so that users who press ctrl-E by habit are not > stopped by nothing happening. Users who browse the menu see > Export As... (the new label) and pick that. > > nobody gets hurt. things work as expected. sneaky, but true. > >> In any case, I have written a patch here: >> https://bugzilla.gnome.org/show_bug.cgi?id=712192 >> >> I guess you can tell if that's good for you > > > Sorry Jehan, no. you change too much and I must say, > with devastating effect. > > first of all I did my job and updated the spec: > > <http://gui.gimp.org/index.php/Save_%2B_export_specification> > > checked 98 occurrences of “export” (twice) and updated > to the new situation. > > in a nutshell, all it is is a string change. > > Export... -> Export As... > > (no other changes to this menu item or the code behind it. > > “Export to” -> Export (when no export target) > > (this is the menu item where “Export to foo.xyz” and > “Overwrite foo.xyz” are swapped in as appropriate) > > do not touch the Save menu items, they work fine, as-is, > since 1984. Save is for the main window content and the > name of that is in the title bar of that main window. > > and that is it. Ok. I'll simplify the patch. Should I change the action's names to follow their label? In particular "Export" would correspond to "file-export" and "Export As..." corresponds to "file-export-as" (otherwise we would end up in the strange situation where "Export" <=> "file-export-to" and "Export As..." <=> "file-export"). Or you care only about UI, not action names, and I should ask Mitch for this? Thanks. Jehan > > --ps > > founder + principal interaction architect > man + machine interface works > > http://blog.mmiworks.net: on interaction architecture > > > > _______________________________________________ > gimp-developer-list mailing list > List address: gimp-developer-list@xxxxxxxxx > List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
