wt: Your new patch looks good, so I committed it. Thanks!
As a side note, I modified the message slightly. We normally include
the general area of the commit (often the top level directory) as a
prefix to the commit message. Also, I removed the "signed off by" line
because we don't really use that.
The short paragraph probably wasn't necessary in this case (we know
what refactoring means), but I left that in anyway. :)
commit 198f2514ab03cd77c769b0cea9678fa0deba4f6e
Author: Warren Turkal <wt@xxxxxxxxxxxxxxxx>
Date: Sat Sep 14 23:46:28 2013 -0700
app: Refactor palette loaders.
I specifically moved the file opening/closing logic to the common
code. This makes the code easier to understand for me since there
is less duplication. In fact, this commit removes more lines than
it adds.
After I committed it, Mitch asked me to change the function names from
your patch on irc. You can see that commit here:
https://git.gnome.org/browse/gimp/commit/?id=d02dd9f0da778640a0a8a82420ee22f9a6efc943
On Mon, Sep 16, 2013 at 4:56 AM, Michael Schumacher <schumaml@xxxxxx> wrote:
>
>
>> Gesendet: Montag, 16. September 2013 um 09:34 Uhr
>> Von: "Warren Turkal" <wt@xxxxxxxxxxxxxxxx>
>
>> I am willing to do whatever is needed to contribute. However, it would be
>> nice if the mailing list wouldn't block patches.
>
> Please keep in mind that those file would be sent out to every subscriber of this mailing list, even those who would not want to receive them. Now imagine people being subscribed to > 10 mailing lists. Would you want to receive all patches and bundles from all the projects you're subscribed to?
>
> The preferred way right now is to open bug reports in Bugzilla and attach your patches there.
>
>> Has anyone taken a look at maybe using gerrit? It's actually a pretty
>> reasonable way to handle code changes when using git. It has a pretty nice
>> code review workflow. Projects like Android and Libreoffice use it. As an
>> example, here's a link
>> <https://gerrit.libreoffice.org/#/q/status:open,n,z>to the Libreoffice
>> instance.
>
> Might be worthwhile to discuss that with GNOME; it's their repository we're using after all.
> They could be interesed in this especially for their GNOME Love bugs, see https://wiki.gnome.org/GnomeLove
>
>
> --
> Regards,
> Michael
> _______________________________________________
> gimp-developer-list mailing list
> List address: gimp-developer-list@xxxxxxxxx
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
_______________________________________________
gimp-developer-list mailing list
List address: gimp-developer-list@xxxxxxxxx
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
