Sorry for taking so long to respond. I don't have a lot of time during normal work days to work on this. :) On Tue, Sep 10, 2013 at 6:10 PM, Michael Henning <drawoc@xxxxxxxxxxxxxxxxxx>wrote: > I made a few minor nitpicks on your commit on github. If you would fix > those points, I'll commit your code to master. > Thanks. I think I addressed all your comments. However, I just added a rewind at the end of gimp_palette_load_detect format instead of doing what your comment suggested. PTAL and see if you approve. Here's the link<https://github.com/wt/gimp/tree/refactor_palette_loader_try2>. I have also attached a patch to this mail. As a side note for the future, the fastest way to get a patch reviewed > is normally if you post it to a pastebin and bother people on irc. > I am not in a huge hurry, and I haven't had much luck catching folks on IRC when I am on. Is there really any benefit of using pastebin over pushing my branch out so that it can be looked at and fetched? The pastebin method seems like it'd be pretty inconvenient for bigger patches, and it doesn't have any kind of commenting on the patch. Also, which pastebin do you prefer? I will say that I was surprised there wasn't more interest in using git to pass around these patches. I would have expected you folks to acquire the patch from my repository (e.g. fetch my branch from my repo and look at the branch directly). I was somewhat surprised by the request for a patch file. With regard to git, I don't see any merges in the history for the project. Does this project not do git merges? -- drawoc > > P.S. I don't see the patch on that last email. Are you sure you attached > it? > It appears to be attached on my end. Does the ML block attachments? FWIW, I also attached the new diff to this email. It indeed does appear to be attached at this point. wt _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
