Re: Uncomitted patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

Thanks for your response.
I'll be on a computer with git somewhere in the next week, and then
I'll resubmit the patches.

And about the palette script, I do believe it should be included since
if we have a palette import built in (for CSS, and for adobe .aco
files) there is nothing wrong in having the palette export script
included as well.

Thanks for your help,

On Wed, Jul 15, 2009 at 12:25 PM, Martin Nordholts<enselic@xxxxxxxxx> wrote:
> On 07/15/2009 11:04 AM, LightningIsMyName wrote:
>>
>> Hello,
>>
>> I have posted several patches for GIMP which only need to be applied,
>> However I see that they haven't recieved a response for about 2
>> months. I know that the developers are busy, but I at least want to
>> know that someone noticed these and that they are somewhere on the
>> list of things to be done.
>>
>> A palettte export script to close a four year old feature request
>> (Souce is attached) - http://bugzilla.gnome.org/show_bug.cgi?id=304399
>> A fix for the bug in the sphere designer plugin (patch is attached) -
>> http://bugzilla.gnome.org/show_bug.cgi?id=582821
>>
>> Note that for the sphere designer, the patch is in gnu diff since I
>> couldn't create a working git repository of gimp (I had issues with
>> git)
>>
>> If any changes need to be done for the patches and this is the cause
>> for the delay, or if there is any way I can apply the patches myself
>> to the source please tell me and I'll do so.
>>
>
> Hi,
>
> The sphere designer patch looks trivial. With risk of coming across as lazy,
> could you reattach that patch as a git commit with git-format-patch please?
> Having patches as git commits makes them about twice as convenient for
> maintainers to apply. The same goes for the palette export script. The
> palette export script looks like good code to me after a quick look. I just
> wonder if that script shouldn't be offered as a third-party plug-in.
>
> BR,
> Martin
>
>
_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux