Re: [PATCH 1/4] Tile caching performance patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'd like to mention also that there are also some minor problems with whitespace

"
ion@gbubuntu:~/st/gimp2/gimp$ git-am /tmp/0002*.patch
Applying Add additional profiling to tile usage in order to analyze
efficiency and behavior of the tile cache. Profiling includes run-time
indication of idle swapper activity.
.dotest/patch:193: trailing whitespace.
  guint zorched : 1;    /* was the tile flushed due to cache pressure
.dotest/patch:255: trailing whitespace.
#endif
.dotest/patch:304: trailing whitespace.
#ifdef TILE_PROFILING
.dotest/patch:318: trailing whitespace.

.dotest/patch:319: trailing whitespace.
#ifdef TILE_PROFILING
warning: squelched 12 whitespace errors
warning: 17 lines add whitespace errors.
ion@gbubuntu:~/st/gimp2/gimp$ git-am /tmp/0003*.patch
Applying Replace two list 'flush clean first' cache strategy with an
LRu strategy. Although the clean-first strategy gives fast light-load
performance, it also degrades catastrophically under moderate cache
pressure. LRU is not as efficient under light load, but degrades more
gracefully under moderate and heavy load.
.dotest/patch:148: trailing whitespace.

.dotest/patch:191: trailing whitespace.

.dotest/patch:196: trailing whitespace.

.dotest/patch:202: trailing whitespace.

.dotest/patch:205: trailing whitespace.

warning: squelched 8 whitespace errors
warning: 13 lines add whitespace errors.
ion@gbubuntu:~/st/gimp2/gimp$ git-am /tmp/0004*.patch
Applying Correct startup flaw in idle swapper start: Don't watch only
UI idling, but also watch that the cache itself is idle. Previously it
would start during transforms and long pyramid rendering ops and toss
writes and large seeks into the tile cache while it was potentially
under heavy pressure.
.dotest/patch:149: trailing whitespace.

.dotest/patch:157: trailing whitespace.

.dotest/patch:158: trailing whitespace.
          if(count>=IDLE_SWAPPER_TILES_PER)
.dotest/patch:186: trailing whitespace.

.dotest/patch:194: trailing whitespace.

warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
"
(patch 0001 applies with no problems.)
_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux