Re: [PATCH 3/4] Tile caching performance patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

a few more coding style despite the ones I already pointed out:

> +  if(!tile)return FALSE;

Please write this as

  if (! tile)
    return FALSE;

> +      if(PENDING_WRITE(t))
> +        acc+=t->size;
> +      t=t->next;

Please insert an empty line like this:

  if (PENDING_WRITE (t))
    acc += t->size;

  t = t->next;


Other than these style issues, the patch looks good. In particular your
benchmarking data looks promising. Nice work!


Sven


_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux