Re: [Gegl-developer] babl portability patches, and a test failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 2009-03-26 at 17:03 -0400, Kevin Cozens wrote:
> Gary V. Vaughan wrote:
> > Has anyone been able to find time to look at my patch queue for babl?
> 
> One minor thing I noticed is the patch which adds and include of config.h so 
> it is done in all(?) files. Is it really necessary to include the header even 
> if it isn't currently needed by some of the files?

Yes, definitely. The config.h header file has defines that affect how
code is compiled. Including it in one place and not in another may
result in bugs that are very hard to track down. It is common practice
to include the config.h header always and always first.


Sven


_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux