Re: [PATCH] About dialog shows unstable status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sven

I have made the required changes (removed newlines; moved message into a
label) except I kept the descriptive text. If you think it's a bad idea
still, I'll remove it. Otherwise, if you are okay with the patch
(attached), I'll commit it.

http://www.mukund.org/temp/about-4.png

Mukund


Index: about.h
===================================================================
RCS file: /cvs/gnome/gimp/app/about.h,v
retrieving revision 1.4
diff -u -p -r1.4 about.h
--- about.h	1 Mar 2006 08:06:08 -0000	1.4
+++ about.h	20 Jul 2006 12:21:55 -0000
@@ -26,6 +26,10 @@
 #define GIMP_NAME \
   _("GNU Image Manipulation Program")
 
+#define GIMP_DESCRIPTION \
+  _("GNU Image Manipulation Program can be used to create new graphics " \
+    "or edit existing ones like photographs."                            )
+
 #define GIMP_COPYRIGHT \
   _("Copyright © 1995-2006\n" \
     "Spencer Kimball, Peter Mattis and the GIMP Development Team")
Index: dialogs/about-dialog.c
===================================================================
RCS file: /cvs/gnome/gimp/app/dialogs/about-dialog.c,v
retrieving revision 1.139
diff -u -p -r1.139 about-dialog.c
--- dialogs/about-dialog.c	20 Jun 2006 09:14:26 -0000	1.139
+++ dialogs/about-dialog.c	20 Jul 2006 12:21:56 -0000
@@ -78,6 +78,11 @@ static gboolean    about_dialog_anim_exp
 static void        about_dialog_reshuffle     (GimpAboutDialog *dialog);
 static gboolean    about_dialog_timer         (gpointer         data);
 
+#ifdef GIMP_UNSTABLE
+static void        about_dialog_add_unstable_message (GtkWidget       *vbox,
+                                                      GimpAboutDialog *dialog);
+#endif
+
 
 GtkWidget *
 about_dialog_create (GimpContext *context)
@@ -110,7 +115,7 @@ about_dialog_create (GimpContext *contex
                              "name",               GIMP_ACRONYM,
                              "version",            GIMP_VERSION,
                              "copyright",          GIMP_COPYRIGHT,
-                             "comments",           GIMP_NAME,
+                             "comments",           GIMP_DESCRIPTION,
                              "license",            GIMP_LICENSE,
                              "wrap-license",       TRUE,
                              "logo",               pixbuf,
@@ -148,7 +153,12 @@ about_dialog_create (GimpContext *contex
       children = gtk_container_get_children (GTK_CONTAINER (container));
 
       if (GTK_IS_VBOX (children->data))
-        about_dialog_add_animation (children->data, dialog);
+        {
+          about_dialog_add_animation (children->data, dialog);
+#ifdef GIMP_UNSTABLE
+          about_dialog_add_unstable_message (children->data, dialog);
+#endif
+        }
       else
         g_warning ("%s: ooops, no vbox in this container?", G_STRLOC);
 
@@ -585,3 +595,25 @@ about_dialog_timer (gpointer data)
   /* else keep the current timeout */
   return TRUE;
 }
+
+#ifdef GIMP_UNSTABLE
+
+static void
+about_dialog_add_unstable_message (GtkWidget       *vbox,
+                                   GimpAboutDialog *dialog)
+{
+    gchar     *text;
+    GtkWidget *label;
+    
+    text = g_strdup_printf ("<span style=\"italic\">%s</span>",
+                            _("This is an unstable development release."));
+    label = gtk_label_new (NULL);
+    gtk_label_set_markup (GTK_LABEL (label), text);
+    gtk_box_pack_start (GTK_BOX (vbox), label, FALSE, FALSE, 0);
+    gtk_box_reorder_child (GTK_BOX (vbox), label, 2);
+    gtk_widget_show (label);
+    g_free (text);
+}
+
+#endif
+

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Gimp-developer mailing list
Gimp-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux