Re: [Gimp-developer] [PATCH] mandrake patches dump

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thierry Vignaud <tvignaud@xxxxxxxxxxxxxxxx> writes:

> > > explaination note for a default that make perl programmers behave
> > > strangely with gimp. by default, gimp perl modules doesn't export
> > > functions, which makes perl programmers became fool ...
> >
> > I don't understand this patch nor the explanation you give. But then
> > I don't know much about Perl.
> 
> one of my coworker tried one day to write perl stuff for gimp but got
> mad since he wasted two hours before understanding the doc was wrong
> since some stuff didn't got imported into namespace, which is what use
> is intended to do.

please file a bug-report then so I can ask the Perl gurus to have a
look at it and to make sure we don't forget about it.

> > > this one is needed so that perl plugins're able to be compiled :
> >
> > what is it you want us to say here? Perl plug-ins don't compile for
> > you?
> 
> yes. gimp-1.1.23 didn't fully compiles without this one, and since
> that day, we've always applied this patch.

I wonder why it is compiling for everyone else then. The patch looks
highly dubious to me but then the whole gimp-perl build system is 
dubious. This is the main reason why the build of gimp-perl is 
disabled in gimp-1.3.

> > > this one forces the font selection dialog to only accept scalable
> > > fonts (which isneeded since gimp forces the dpi of the font to dpi
> > > of the image, and so fails on non-scalable fonts) :
> >
> > this is only true if the user chooses to enter the size in Points.
> 
> you see, distro maintainer job is to make programs that works for
> everybody :-)
> 
> > The gimp-1-2 CVS tree already has some changes that addresses this
> > problem. See http://bugzilla.gnome.org/show_bug.cgi?id=58848
> 
> the bug really is that gimp try to apply image dpi to the font
> setting, and fonts don't provides/support all dpi settings.
> it'll work with "classic" dpi setting ... but not for everybody.
> if you create an image with a strange resolution *then* you'll enter
> the devil lands :-(
>
> as far as i can see, this has nothing to do with anti-aliasing but the
> fact that gimp blindy try to force font to enforce the image
> resolution even for non scalable fonts which cannot do this by
> definition.
> hence the patch.

your patch doesn't fix the problem since unconditionally disabling
non-scalable fonts is not an option. 

> > Could you please check Bugzilla for existing bug-reports regarding
> > your problems and attach your patches to these reports or open new
> > bug-reports. Thanks a lot.
> 
> humm. once the bug is spotten and a fix is availlable, i see no point
> to use such db but it's just my 2 cents.

well, you won't get anything changed in The GIMP if you refuse to use
Bugzilla. It helps us a lot and we won't be able to handle the amount
of bug-reports we receive without a bug-tracking system. You seem to
forget that you ask for changes in the stable GIMP tree. We can't do
such changes without reviewing them extensively. Fixes tend to break
stuff that used to work. It already happended often enough. We will
certainly not accept any patches for 1.2 without them being submitted
to Bugzilla.


Salut, Sven


[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux