Re: Remove the Stack Trace...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 24, 2000 at 06:31:24PM +0100, Raphael Quinet wrote:
> On Mon, 24 Jan 2000, Austin Donnelly <austin@xxxxxxxx> wrote:
> > On Monday, 24 Jan 2000, Glyph Lefkowitz wrote:
> > > Since the only advantage of this is the stack-trace for non-developers,
> > > why don't we just have it dump stack, then die, by default.
> > 
> > This sounds sensible, but also add a check on istty(stdout) being
> > true.  No point taking forever doing a backtrace if no-one's going to
> > see it.
> 
> If I am not mistaken, the call to isatty() is already done inside glib.
> In glib (gerror.c), if the current terminal is not a tty, then the
> program will immediately exit instead of asking for a stack trace or
> whatever.

Yep.
 
> I know a bit of configure, so if nobody else is interested in
> implementing this simple change (a couple of lines, I think), then I
> will do that tomorrow.
> 
> Any suggestions for the name of the new option?  It could be something
> like "--disable-stack-trace" or "--disable-crash-query", assuming that
> the default behaviour would be to have it enabled in unstable releases.
> Note that I also support the idea posted some time ago on this list
> that suggested to enable most debugging options in the unstable
> releases, but to disable them by default in the stable releases (so
> that you would have to use the opposite option --enable-crash-query if
> you wanted that feature).  And maybe the people building RPMs or other
> pre-compiled packages should disable these options as part of the
> build rules also for unstable releases if they think that it is better.

How about --enable-stack-trace=[yes/no/query] and set it to query by default.
We'll set the default to no for stable releases.

This should just set the default setting that gimp uses at runtime. There
should be runtime options that parallel to override.

-Yosh


[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux