Re: [patch] gimp-drawable-get/set-pixel bugfix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, 10 Nov 1999, Tamito KAJIYAMA wrote:

> I found a bug that gimp-drawable-get/set-pixel swapped the
> specified x and y coordinates when getting/setting a pixel.

Ouch!

gimp-drawable-{get,set}-pixel is such a slow API not many people use
it, I reckon.  That's probably why it's taken so long to crawl out of
the woodwork.

> --- drawable_cmds.c.orig	Thu Oct  7 04:55:27 1999
> +++ drawable_cmds.c	Mon Nov  8 17:38:15 1999
> @@ -1057,7 +1057,7 @@
>  	  x %= TILE_WIDTH;
>  	  y %= TILE_WIDTH;

This is another bug - if we ever go to non-square tiles this will
break.  It should read:

x %= TILE_WIDTH;
y %= TILE_HEIGHT;

Thanks for bringing this to our attention, good work.

Austin


[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux