On Mon, 8 Nov 1999 17:13:08 +0000 (GMT), Austin Donnelly wrote:
>> The GIMP's modules for OS/2 need some extra handling.
>> It's copied into the 3-4 modules C files and it's also not
>> updated. I want to clean up this code.
>
>The same problem was occurring on Solaris2. Yosh has now tweaked some
>of the libtool options so that it should now work. Do these fixes for
>Solaris2 also fix the problem under OS/2?
I'm not useing libtool, and i prefer to fix problems at run-time not at LINK-time.
Problems and inputs should be solved/handled in the code and not in compiler,linker,loader,fork,,,.
Here is an example with gimp_main() (for plug-ins)
UNIX:
int main (int argc, char *argv[])
{
return gimp_main (argc, argv);
}
OS/2:
int main (int argc, char *argv[])
{
set_gimp_PLUG_IN_INFO(&PLUG_IN_INFO); /* Yes it's input to gimp_main() */
return gimp_main (argc, argv);
}
The OS/2 and UNIX code is doing the same !
The structure PLUG_IN_INFO is a REAL input and should be a parameter
input to gimp_main(). ex: gimp_main(argc,argv, &PLUG_IN_INFO);
On UNIX they trust/use fork() to input the structure, but my OS/2 version will work
on all system with or without forking.
It's more readable too.
>
>> I suggest to create a new file called modregister.c and put
>> all the "register" things there. Modules have to link the new file.
>>
>> The will be no new features only a cleaner design.
>
>I'm all for a cleaner design. Ideally we should be doing the same
>thing for all architectures, rather than using nasty #ifdefs
>everywhere.
>
>Also, still to be fixed with the module code is a version check as
>suggested by Tim Janik a long time ago, and unloading modules from the
>idle loop (which should make the perl module self-unloadable).
>
>I'm not particularly happy with the OS/2 solution, it seems a little
>ugly, but I'm not sure why exactly I don't like it.
I don't like it either. That's why i want to clean it up.
>
>Austin
Asbjoern P.
***********************************************************
* Asbjørn Pettersen Phone work: +47 77 66 08 91 *
* Kongsberg Spacetec a.s Phone home: +47 77674022 *
* Telefax: +47 77 65 58 59 *
* Prestvannveien 38 www:http://www.spacetec.no *
* N-9005 Tromsoe, Norway email:ape@xxxxxxxxxxx *
***********************************************************
