free-select segfault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gimp 1.1.10 sometimes segfaults when the mouse is moved
above or below the window dureing a free select. I've
attached a patch that seems to fix it. The problem was an
unchecked variable in scan_convert.c. There is a similar but
unrelated problem when the mouse is moved to the left of the
window. I haven't found that bug yet.
Ben
--- scan_convert.c.old	Thu Oct 21 00:24:58 1999
+++ scan_convert.c	Thu Oct 21 00:27:08 1999
@@ -121,8 +121,11 @@
     else
     {
 	/* horizontal line */
-	scanlines[y1] = insert_into_sorted_list (scanlines[y1], ROUND (x1));
-	scanlines[y1] = insert_into_sorted_list (scanlines[y1], ROUND (x2));
+        if (y1 >= 0 && y1 < height)
+	  {
+	    scanlines[y1] = insert_into_sorted_list (scanlines[y1], ROUND (x1));
+	    scanlines[y1] = insert_into_sorted_list (scanlines[y1], ROUND (x2));
+	  }
     }
 }
 

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux