Re: [Gimp-docs] re: CR+LF in src/menus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Might it be possible (or a good idea) to use a command like this as
> a front-end to a cvs checkin automatically?  I don't know if this
> is do-able or how to do it, but it seems like a possibility.
> 
> Red-facedly yours,
> 

Sally, really there is no problem with that CR+LF, it's very easy to
clean them, sorry for any troubles. The only thing that I am asking is -
may I commit this large fix? Let me emphasis the question: "May I commit
a fix?" :)

Btw, kate doesn't show CR, I use mcedit from Midnight commander, it
nicely shows ^M in the end of lines. Kate seems to have an option for
Unix/Dos EOLs but it's selected automatically according to the file
contents. There is also a nice option to strip trailing backspaces in
preferences, it will strip the CR symbols.

To drop such bugs in the future we may want to apply the following patch
to makefile which adds additional check to validation rule. 

Index: Makefile.am
===================================================================
RCS file: /cvs/gnome/gimp-help-2/Makefile.am,v
retrieving revision 1.84
diff -u -p -r1.84 Makefile.am
--- Makefile.am	14 Jul 2006 20:32:00 -0000	1.84
+++ Makefile.am	20 Sep 2006 15:39:45 -0000
@@ -259,8 +259,12 @@ $(STAMP_DIR)/validate.stamp: $(patsubst 
 
 $(patsubst %,$(STAMP_DIR)/validate.%.stamp,$(ALL_LINGUAS)): $(STAMP_DIR)/validate.%.stamp : $(STAMP_DIR)/profile.%.stamp
 	@echo -n '-- Validating XML for '$*; \
-	$(XMLLINT) --noout --valid xml/$*.xml >/dev/null 2>xml/$*-validity-errors.log; \
-	echo -n '	number of errors: '; \
+	$(XMLLINT) --noout --valid xml/$*.xml >/dev/null 2>xml/$*-validity-errors.log;
+	@find src -name "*.xml" | while read f; do \
+	    if grep -qU $$(echo -en '\r') $$f; then\
+	        echo "validity error: Carriage return detected in $$f" >> xml/$*-validity-errors.log; \
+	fi; done;
+	@echo -n '	number of errors: '; \
 	grep "validity error" xml/$*-validity-errors.log | wc -l
 
 	@touch $@
_______________________________________________
Gimp-docs mailing list
Gimp-docs@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-docs

[Index of Archives]     [Video For Linux]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [Scanners]     [GEGL]     [Gimp's Home]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux