On Sun, 2016-05-15 at 20:29 +0000, pippin@xxxxxxxx wrote: > On Sun, May 15, 2016 at 04:03:22PM -0400, Jan Vesely wrote: > > > > On Sun, 2016-05-15 at 14:12 +0200, Øyvind Kolås wrote: > > > > > > Please use bugzilla which is GEGLs normal patch/bug handling > > > system. > > > I've pushed these changes to git master - albeit with slightly > > > deteriorated meta data since the diffs were manually > > > incorporated. > > thank you, I'll use bugzilla next time. I assumed everybody just > > uses > > git am. > We do use git am formatted patches - but attached to bugs in bugzilla > instead > of sent to the mailinglist - they might linger for a while, but at > least not be > forgotten like messages to the mailinglist more readily might be. I > have > workflows for picking patches from bugzilla attachements, but no > sensible way > to get your contribution without more manual intervention out of the > mail > (clients). > > > > > The unexpected part is that the test now passes, despite not doing > > any > > processing. I have attached diff between reference and OpenCL > > result. > > note that CPU version of the algorithm produces the exact same > > picture > > as OpenCL (which did no processing) > Odd,. both http://gegl.org/operations.html#gegl%3Avideo-degradation > and > https://git.gnome.org/browse/gegl/plain/tests/compositions/reference/ > video-degradation.png > seem to have processing happening to me. I investigated a bit further: $ rm tests/compositions/output/* $ GEGL_USE_OPENCL=no make check ... /home/vesely/gegl/tests/compositions/reference/video-degradation.png and /home/vesely/gegl/tests/compositions/output/video-degradation.png are identical PASS video-degradation.xml SKIP video-degradation.xml (OpenCL) ... $ diff /home/vesely/gegl/tests/compositions/reference/video-degradation.png /home/vesely/gegl/tests/compositions/output/video-degradation.png Binary files /home/vesely/gegl/tests/compositions/reference/video-degradation.png and /home/vesely/gegl/tests/compositions/output/video-degradation.png differ $ compare /home/vesely/gegl/tests/compositions/reference/video-degradation.png /home/vesely/gegl/tests/compositions/output/video-degradation.png -compose src diff-cpu.png (see attachment) with OpenCL (unconditionally goto error), the cpu output is the same as above, and comparing opencl output gives: /home/vesely/gegl/tests/compositions/reference/video-degradation.png and /home/vesely/gegl/tests/compositions/output/video-degradation.png are identical PASS video-degradation.xml (lt-gegl:6636): GLib-GObject-WARNING **: Two different plugins tried to register 'GeglOpload_c'. (lt-gegl-imgcmp:6662): GLib-GObject-WARNING **: Two different plugins tried to register 'GeglOpload_c'. /home/vesely/gegl/tests/compositions/reference/video-degradation.png and /home/vesely/gegl/tests/compositions/output/opencl-video-degradation.png are identical PASS video-degradation.xml (OpenCL) $ diff ~/gegl/tests/compositions/output/video-degradation.png ~/gegl/tests/compositions/output/opencl-video-degradation.png $ fixing the original OpenCL error produces the same output as CPU version. am I doing something wrong? Jan > > /pippin -- Jan Vesely <jan.vesely@xxxxxxxxxxx>
Attachment:
diff-cpu.png
Description: PNG image
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ gegl-developer-list mailing list List address: gegl-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gegl-developer-list
