Hi, thank you for your response. On Sat, 2014-06-07 at 22:31 +0200, scl wrote: > On 5.6.2014 at 3:09 PM Jan Vesely wrote: > > gentle ping > > > > On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote: > >> No static keyword, f suffix for float constants > >> Fixes one error and 7 warnings > > Hi Jan, > > first of all thank you for your work! > I'm more active in the GIMP project than in GEGL, > but I appreciate your efforts and would like to > push it a bit further, so here we go: > > - Is your code tested or can you provide test > drivers that fit into the GEGL codebase? yes, the noise-simplex.xml test passes on my AMD TURKS gpu (Radeon HD 7570). I'm not sure how to provide a test driver. I also ran the gegl testsuite on Intel OCL SDK and this patch does not change any result (all tests pass) > - I could try to test the code, but I only have > Linux in a Virtualbox VM. Can you tell whether > Mesa/Gallium3d/OpenCL would work in such an > environment? It won't. VBox does not use mesa at all. you'd need linux running on a machine with amd gpu to test it, as well as recent versions of mesa, clang, llvm, and libclc . It should be possible to test ocl 1.1 syntax using clang CLC frontend but I have not investigated it. > - Are there any side effects of the patch known > (especially from making the static variable > a non-static one)? No side effects. static keyword is removed from a function not variable (although it's not supported for either in OCL 1.1) this patch is in line with previous modifications to make ocl kernels ocl 1.1 complaint: https://git.gnome.org/browse/gegl/commit/?id=75fc532a561ddcf3f4d50c26b94aa31b047abfa9 https://git.gnome.org/browse/gegl/commit/?id=1fb0a80f236d8ed75146e57e568b19ff1d906d99 https://git.gnome.org/browse/gegl/commit/?id=bd9f98e2b0c4add1325a62a88260fbd01cab6143 the only difference is that this time the associated .h file is not in the repository (not sure if it's intentional) thank you, Jan > > Kind regards, > > Sven > > _______________________________________________ > gegl-developer-list mailing list > List address: gegl-developer-list@xxxxxxxxx > List membership: https://mail.gnome.org/mailman/listinfo/gegl-developer-list > -- Jan Vesely <jan.vesely@xxxxxxxxxxx>
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ gegl-developer-list mailing list List address: gegl-developer-list@xxxxxxxxx List membership: https://mail.gnome.org/mailman/listinfo/gegl-developer-list
