Re: BABL fishing patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 7, 2008 at 5:31 PM, Jan Heller <jan.heller@xxxxxxxxx> wrote:
>   attached is a patch that improves logic of go_fishing code
>   in babl-fish.c. The current code searches list of all
>   fishes while looking for suitable preexistent
>   BABL_FISH_PATH instance. The new code only searches
>   relevant part of database's hash table. Further, the
>   current code searches for fish path every time such a babl
>   fish is requested, even though the same fish path has been
>   requested before and not found. The new code creates dummy
>   BABL_FISH instance with appropriate source/destination
>   formats and inserts it into the fish database to indicate
>   that fish path has been searched for and not found. See
>   comments in the patch for details.

One thing you could do to improve the process of applying your already
excellent patches for babl is to provide a draft ChangeLog entry as
well. If you continue at this pace we might have to start working on
getting you commit access to the svn repository.

Thanks a lot for the good work thus far.

/Øyvind K.
-- 
«The future is already here. It's just not very evenly distributed»
 -- William Gibson
http://pippin.gimp.org/ http://ffii.org/
_______________________________________________
Gegl-developer mailing list
Gegl-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer


[Index of Archives]     [Yosemite News]     [Yosemite Photos]     [gtk]     [GIMP Users]     [KDE]     [Gimp's Home]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux