Hi Alex, On Sun, 2024-07-14 at 15:31 +0200, Alejandro Colomar wrote: > On Sun, Jul 14, 2024 at 01:37:02PM GMT, Jonathan Wakely wrote: > > On Sun, 14 Jul 2024, 12:30 Alejandro Colomar via Gcc-help, < > > gcc-help@xxxxxxxxxxx> wrote: > > > Did I break anything? I see the failure being `git diff --exit-code`, > > > which doesn't seem like anything broken, but I don't know what that test > > > is for, so I'll ask. > > > > > > > It checks that necessary auto-generated files have been regenerated and > > committed. > > > > If you didn't do anything related to that warning option that would have > > affected the c.opts.urls file then it wasn't you (I think it was a change > > from Marek). > > I did add that warning option: > > commit 44c9403ed1833ae71a59e84f9e37af3182be0df5 > Author: Alejandro Colomar <alx@xxxxxxxxxx> > AuthorDate: Sat Jun 29 15:10:43 2024 +0200 > Commit: Martin Uecker <uecker@xxxxxxxxxxx> > CommitDate: Sun Jul 14 11:41:00 2024 +0200 > > c, objc: Add -Wunterminated-string-initialization > > Warn about the following: > > char s[3] = "foo"; > > I guess I should have committed some re-generated files? Is that > documented somewhere? Adding David Malcolm to CC who might know where this is documented. But yes, after adding a new warning option you should run: make html && cd gcc && make regenerate-opt-urls This will produce the needed opt.url changes you should commit together with your change. In this case: diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls index 1b60ae4847b..df5f58a1eee 100644 --- a/gcc/c-family/c.opt.urls +++ b/gcc/c-family/c.opt.urls @@ -870,6 +870,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wno-unknown-pragmas) LangUrlSuffix_D(gd Wunsuffixed-float-constants UrlSuffix(gcc/Warning-Options.html#index-Wno-unsuffixed-float-constants) +Wunterminated-string-initialization +UrlSuffix(gcc/Warning-Options.html#index-Wno-unterminated-string-initialization) + Wunused UrlSuffix(gcc/Warning-Options.html#index-Wno-unused) Cheers, Mark
