-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/06/11 11:26, Axel Freyn wrote: > Hi, > > I'm trying to understand gcc-internals a bit more at the moment. Looking > at the main driver, I found three lines in opts-common.c which are > probably useless: > > Here's a possible patch against svn:172056 (generate by git) > ######################################################################## > diff --git a/gcc/opts-common.c b/gcc/opts-common.c > index e314cb3..089d819 100644 > --- a/gcc/opts-common.c > +++ b/gcc/opts-common.c > @@ -693,7 +693,6 @@ decode_cmdline_options_to_array (unsigned int argc, > const char **argv, > unsigned int n, i; > struct cl_decoded_option *opt_array; > unsigned int num_decoded_options; > - bool argv_copied = false; > > opt_array = XNEWVEC (struct cl_decoded_option, argc); > > @@ -728,8 +727,6 @@ decode_cmdline_options_to_array (unsigned int argc, > const char **argv, > num_decoded_options++; > } > > - if (argv_copied) > - free (argv); > *decoded_options = opt_array; > *decoded_options_count = num_decoded_options; > prune_options (decoded_options, decoded_options_count); > ######################################################################## > > Those lines were introduced in svn:164531 (22. Sep. 2010), but in > svn:166534 (10. Nov. 2010) the part which could change "argv_copied" > was removed. As no-where in the trunk "argv_copied" appears, it really > seems useless to me at the moment? They look useless to me. > > Axel > > (Is that the best list for such "patcheÑ" -- or would be gcc-patches > more adequate? And I hope the mail contains all necessary informations) gcc-patches@xxxxxxxxxxx the right place. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNnKM3AAoJEBRtltQi2kC755MH/3EdgsPG5kTu/2cLIomLQuVS FuL5e2if5XQ7WZOM6zT/OFe56/2YSkbt13VeuXVcyjWgXEXZpK3ueEl6p4Ts/tzN gomVZ2vOq7jFu9dTejozw1J4gMON9cE6lBkj50LglgmKkAOUPVn7VkJsU7RU319D hoAlgTqmhdwz8B6cfokWKXVSoH/Rd0ipFScmV1P/0s8r/cz3dw0a1CwAFfEX/Qf1 an/4SGlYMc2+lqsnHzhYS6oh+SU5GRXBc+vKleo1nkGhXQN1+IWWfAu/frIP+peF UbZt+T4uZixdik1VrbV0IEOh1OioaZiBL453AuIilKeeZnosdZts6x31Y8cbquE= =4mx6 -----END PGP SIGNATURE-----
