Re: [PATCH 05/13] common: allow _require_non_zoned_device without an argument

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Mar 21, 2025 at 08:21:34AM +0100, Christoph Hellwig wrote:
> So that callers can pass $SCRATCH_RTDEV directly without needing to check
> that it actually is set.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  common/rc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index 7cd8d5ffd2e8..dc6d4ce01e05 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2545,8 +2545,7 @@ _require_non_zoned_device()
>  {
>  	local target=$1
>  	if [ -z $target ]; then
> -		echo "Usage: _require_non_zoned_device <device>"
> -		exit 1
> +		return
>  	fi
>  
>  	local type=`_zone_type ${target}`
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux