On Sun, Mar 16, 2025 at 10:48:50AM -0500, Eric Sandeen wrote: > On 3/16/25 9:54 AM, Zorro Lang wrote: > > On Mon, Mar 10, 2025 at 01:29:09PM -0500, Eric Sandeen wrote: > >> sparse points out that lots of things in random.c could be static, > >> and upon doing so we realize that nothing in this file is used. > >> Which is unsurprising since these are all part of the standard > >> C library ... so just remove the file. > >> > >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > >> Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> > >> Reviewed-by: Christoph Hellwig <hch@xxxxxx> > >> --- > > > > Hi Eric, > > > > When I did the fstests regression test this weekend, I found a regression > > failure on generic/007 (diff output): > > > > --- /dev/fd/63 2025-03-15 13:31:35.044534292 -0400 > > +++ generic/007.out.bad 2025-03-15 13:31:35.002455111 -0400 > > @@ -14,9 +14,9 @@ > > ......................................................................... > > ......................................................................... > > .................................................... > > -creates: 18736 OK, 18802 EEXIST ( 37538 total, 50% EEXIST) > > -removes: 18675 OK, 19927 ENOENT ( 38602 total, 51% ENOENT) > > -lookups: 12000 OK, 11860 ENOENT ( 23860 total, 49% ENOENT) > > -total : 49411 OK, 50589 w/error (100000 total, 50% w/error) > > +creates: 18839 OK, 18890 EEXIST ( 37729 total, 50% EEXIST) > > +removes: 18783 OK, 19951 ENOENT ( 38734 total, 51% ENOENT) > > +lookups: 11858 OK, 11679 ENOENT ( 23537 total, 49% ENOENT) > > +total : 49480 OK, 50520 w/error (100000 total, 50% w/error) > > > > -cleanup: 61 removes > > +cleanup: 56 removes > > > > By bisecting, the first failed commit is this patch. After removing > > the fstests internal lib/random.c, the output of src/nametest.c is > > changed too, that breaks the g/007 (xfs/188 maybe too) test. > > > > It fails on all filesystems (e.g. xfs, ext2/3/4, btrfs, tmpfs, nfs, > > cifs etc). I'll defer the release of this week (03.16), hope we can > > fix this regression next week :) > > Oh no, I'm sorry. I thought that if this stuff was never used it'd > be safe to just yank, but I clearly must have missed something. > > It's probably best to just revert/remove this patch for now, so it > doesn't delay any release. Sure, thanks Eric. Not only generic/007, generic/311 fails on this patch too. I'll revert this patch, then release fstests. > > -Eric >
