Re: [PATCH 14/17] xfs: skip filestreams tests on internal RT devices

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 12, 2025 at 07:45:06AM +0100, Christoph Hellwig wrote:
> The filestreams tests using _test_streams force a run on the data
> section, but for internal RT zoned devices the data section can be tiny
> and might not provide enough space.  Skip these tests as they aren't
> really useful when testing a zoned config anyway.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok, assuming you don't just want to kill filestreams entirely :)
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  common/filestreams | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/common/filestreams b/common/filestreams
> index 00b28066873f..bb8459405b3e 100644
> --- a/common/filestreams
> +++ b/common/filestreams
> @@ -108,6 +108,11 @@ _test_streams() {
>  		_scratch_mount
>  	fi
>  
> +	# Skip these tests on zoned file systems as filestreams don't work
> +	# with the zoned allocator, and the above would force it into the
> +	# tiny data section only used for metadata anyway.
> +	_require_xfs_scratch_non_zoned
> +
>  	cd $SCRATCH_MNT
>  
>  	# start $stream_count streams
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux