Re: [PATCH 04/17] common: extend the zoned device checks in _require_dm_target

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 12, 2025 at 07:44:56AM +0100, Christoph Hellwig wrote:
> Also check for zoned log and rt devices in _require_dm_target
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  common/rc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index dcdfa86e43b1..753e86f91a04 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2501,6 +2501,12 @@ _require_dm_target()
>  	case $target in
>  	snapshot|thin-pool)
>  		_require_non_zoned_device ${SCRATCH_DEV}
> +	        if [ "$FSTYP" = "xfs" ] && [ -b "$SCRATCH_RTDEV" ]; then

Silly nit: -n not -b, to be consistent with the codebase?

(Doesn't really matter since _require_non_zoned_device never aborts the
test if it's fed something that isn't a block device)

Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> +			_require_non_zoned_device ${SCRATCH_RTDEV}
> +		fi
> +	        if [ "$FSTYP" = "xfs" ] && [ -b "$SCRATCH_LOGDEV" ]; then
> +			_require_non_zoned_device ${SCRATCH_LOGDEV}
> +		fi
>  		;;
>  	esac
>  }
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux